Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 23756003: Use the same IP address for both server and client in web_socket_pipe_test (Closed)

Created:
7 years, 3 months ago by Søren Gjesse
Modified:
7 years, 1 month ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use the same IP address for both server and client in web_socket_pipe_test On Mac OS and Windows localhost by default resolve to IPv6 address ::1. Also improve web_socket_pipe_test code and style as previously suggested. R=whesse@google.com BUG=http://dartbug.com/12974 Committed: https://code.google.com/p/dart/source/detail?r=27012

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -22 lines) Patch
M tests/standalone/io/web_socket_pipe_test.dart View 1 2 chunks +16 lines, -20 lines 0 comments Download
M tests/standalone/standalone.status View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 3 months ago (2013-09-02 11:37:40 UTC) #1
Bill Hesse
lgtm https://codereview.chromium.org/23756003/diff/1/tests/standalone/io/web_socket_pipe_test.dart File tests/standalone/io/web_socket_pipe_test.dart (right): https://codereview.chromium.org/23756003/diff/1/tests/standalone/io/web_socket_pipe_test.dart#newcode48 tests/standalone/io/web_socket_pipe_test.dart:48: (data) { I still think this is wrong ...
7 years, 3 months ago (2013-09-02 11:41:31 UTC) #2
Søren Gjesse
Committed patchset #2 manually as r27012 (presubmit successful).
7 years, 3 months ago (2013-09-02 12:01:37 UTC) #3
Søren Gjesse
7 years, 1 month ago (2013-10-28 11:33:38 UTC) #4
Message was sent while issue was closed.
Publishing old comment

https://codereview.chromium.org/23756003/diff/1/tests/standalone/io/web_socke...
File tests/standalone/io/web_socket_pipe_test.dart (right):

https://codereview.chromium.org/23756003/diff/1/tests/standalone/io/web_socke...
tests/standalone/io/web_socket_pipe_test.dart:48: (data) {
On 2013/09/02 11:41:31, Bill Hesse wrote:
> I still think this is wrong - in this case, (data) should be 4 spaces, and the
> next line either 2 or 6 - I don't know which.
> 
> If (data) is on the same line as client.listen, then I think the next line
> should be indented 2 spaces.

Done.

Powered by Google App Engine
This is Rietveld 408576698