Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 23756002: Allow inlining of methods that have an intrinsic translation. (Closed)

Created:
7 years, 3 months ago by Florian Schneider
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Allow inlining of methods that have an intrinsic translation. This works because I changed the compiler so that it always emit the full unoptimized code for all intrinsic methods in a previous CL As a result deoptimization works for those methods like for normal methods. Also, code for some recognized getter methods is moved to the flow graph builder, so that there is no need for special handling in the flow graph optimizer. This part of the change is should be performance-neutral. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=26867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -80 lines) Patch
M runtime/vm/flow_graph_builder.cc View 3 chunks +44 lines, -10 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 3 chunks +0 lines, -59 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
7 years, 3 months ago (2013-08-29 11:22:22 UTC) #1
Kevin Millikin (Google)
LGTM.
7 years, 3 months ago (2013-08-29 12:10:36 UTC) #2
Florian Schneider
7 years, 3 months ago (2013-08-29 12:32:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26867 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698