Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 23754012: Fix docs_test. I just learned that when updating docs under html we also need to (Closed)

Created:
7 years, 3 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 3 months ago
Reviewers:
Emily Fortuna, siva, mem
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix docs_test. I just learned that when updating docs under html we also need to run: python tools/dom/dom.py docs R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=27404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M tools/dom/docs/docs.json View 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
Hi Mem, It seems like our tests broke from a recent change in the html ...
7 years, 3 months ago (2013-09-11 21:03:39 UTC) #1
Emily Fortuna
lgtm
7 years, 3 months ago (2013-09-11 21:06:15 UTC) #2
Siggi Cherem (dart-lang)
Committed patchset #1 manually as r27404 (presubmit successful).
7 years, 3 months ago (2013-09-11 21:07:52 UTC) #3
siva
7 years, 3 months ago (2013-09-12 21:28:05 UTC) #4
Message was sent while issue was closed.
This results in a diff in the generated dart files stored in the repository
(output of go.sh). I have uploaded a CL

https://codereview.chromium.org/23533055/

to fix this.

Powered by Google App Engine
This is Rietveld 408576698