Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 237493005: Adding Node.baseUri to CustomElement. (Closed)

Created:
6 years, 8 months ago by blois
Modified:
6 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding Node.baseUri to CustomElement. This was added with https://code.google.com/p/dart/source/detail?r=35041, but I missed the CustomElement package. TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=35043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M pkg/custom_element/lib/custom_element.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
Committed patchset #1 manually as r35043 (presubmit successful).
6 years, 8 months ago (2014-04-14 21:51:15 UTC) #1
Jennifer Messerly
lgtm
6 years, 8 months ago (2014-04-14 22:11:29 UTC) #2
Jennifer Messerly
6 years, 8 months ago (2014-04-14 23:31:16 UTC) #3
Message was sent while issue was closed.
@kevmoo pointed out: we should probably bump pubspec.yaml for these, so it has
an appropriate SDK constraint.

Powered by Google App Engine
This is Rietveld 408576698