Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 23742002: Fix observable transform bug introduced in a recent change, add regression tests (Closed)

Created:
7 years, 3 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix observable transform bug introduced in a recent change, add regression tests for it. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=26836

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M pkg/observe/lib/transform.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/observe/test/transform_test.dart View 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
7 years, 3 months ago (2013-08-29 01:11:06 UTC) #1
Jennifer Messerly
lgtm
7 years, 3 months ago (2013-08-29 01:23:12 UTC) #2
Siggi Cherem (dart-lang)
7 years, 3 months ago (2013-08-29 01:32:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26836 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698