Issue 237343002: pkg/docgen: sort output files

Issue 237343002: pkg/docgen: sort output files (Closed)

Created:
6 years, 8 months ago by kevmoo

Modified:
6 years, 8 months ago

Reviewers:
Alan Knight, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/docgen: sort output files R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=35032

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -9 lines)			Patch
M	pkg/docgen/bin/docgen.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/docgen/lib/src/generator.dart	View	5 chunks	+20 lines, -4 lines	2 comments	Download
M	pkg/docgen/lib/src/model_helpers.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	pkg/docgen/lib/src/models.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Alan Knight

https://codereview.chromium.org/237343002/diff/1/pkg/docgen/lib/src/generator.dart File pkg/docgen/lib/src/generator.dart (right): https://codereview.chromium.org/237343002/diff/1/pkg/docgen/lib/src/generator.dart#newcode188 pkg/docgen/lib/src/generator.dart:188: } Why can't we just compare the qualified name ...

6 years, 8 months ago (2014-04-14 17:33:30 UTC) #3

kevmoo

Committed patchset #1 manually as r35032 (presubmit successful).

6 years, 8 months ago (2014-04-14 17:33:56 UTC) #4

kevmoo

6 years, 8 months ago (2014-04-14 17:35:37 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/237343002/diff/1/pkg/docgen/lib/src/generator...
File pkg/docgen/lib/src/generator.dart (right):

https://codereview.chromium.org/237343002/diff/1/pkg/docgen/lib/src/generator...
pkg/docgen/lib/src/generator.dart:188: }
On 2014/04/14 17:33:30, Alan Knight wrote:
> Why can't we just compare the qualified name of libraries, when that's what we
> do for everything else?

Because core libraries don't have a qualified prefix, so they end up sorted in
the middle of the content (after the packages starting with "C")

This fix ensures that dart:core libs show up first

Expand Messages | Collapse Messages