Issue 237313004: Improve double pow performance for few simple exponents (0.0, 1.0, 2.0, 3.0).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 237313004: Improve double pow performance for few simple exponents (0.0, 1.0, 2.0, 3.0). (Closed)

Created:
6 years, 8 months ago by srdjan

Modified:
6 years, 8 months ago

Reviewers:
Cutch, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improve double pow performance for few simple exponents (0.0, 1.0, 2.0, 3.0). R=iposva@google.com, johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=35035

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	runtime/lib/math_patch.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	runtime/vm/intermediate_language.h	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm https://codereview.chromium.org/237313004/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/237313004/diff/1/runtime/vm/intermediate_language.h#newcode92 runtime/vm/intermediate_language.h:92: V(::, _doublePow, MathDoublePow, 2098142859) \ Just curious, why ...

6 years, 8 months ago (2014-04-14 17:50:05 UTC) #2

srdjan

https://codereview.chromium.org/237313004/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/237313004/diff/1/runtime/vm/intermediate_language.h#newcode92 runtime/vm/intermediate_language.h:92: V(::, _doublePow, MathDoublePow, 2098142859) \ On 2014/04/14 17:50:05, Cutch ...

6 years, 8 months ago (2014-04-14 17:53:32 UTC) #3

srdjan

6 years, 8 months ago (2014-04-14 18:04:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r35035 (presubmit successful).

Expand Messages | Collapse Messages