Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 23726002: Path fixes for formatter main. (Closed)

Created:
7 years, 3 months ago by pquitslund
Modified:
7 years, 3 months ago
Reviewers:
Bob Nystrom, scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M pkg/analyzer_experimental/bin/formatter.dart View 3 chunks +3 lines, -5 lines 4 comments Download

Messages

Total messages: 5 (0 generated)
pquitslund
7 years, 3 months ago (2013-08-28 18:15:49 UTC) #1
Bob Nystrom
Two things, then LGTM. https://codereview.chromium.org/23726002/diff/1/pkg/analyzer_experimental/bin/formatter.dart File pkg/analyzer_experimental/bin/formatter.dart (right): https://codereview.chromium.org/23726002/diff/1/pkg/analyzer_experimental/bin/formatter.dart#newcode10 pkg/analyzer_experimental/bin/formatter.dart:10: import 'package:path/path.dart' as path; Don't ...
7 years, 3 months ago (2013-08-28 18:18:55 UTC) #2
scheglov
lgtm
7 years, 3 months ago (2013-08-28 18:20:58 UTC) #3
pquitslund
Thanks! https://codereview.chromium.org/23726002/diff/1/pkg/analyzer_experimental/bin/formatter.dart File pkg/analyzer_experimental/bin/formatter.dart (right): https://codereview.chromium.org/23726002/diff/1/pkg/analyzer_experimental/bin/formatter.dart#newcode10 pkg/analyzer_experimental/bin/formatter.dart:10: import 'package:path/path.dart' as path; On 2013/08/28 18:18:55, Bob ...
7 years, 3 months ago (2013-08-28 20:29:13 UTC) #4
pquitslund
7 years, 3 months ago (2013-08-28 20:29:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r26815 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698