Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 23724022: pkg/mdv: remove reference to pkg/serialization (Closed)

Created:
7 years, 3 months ago by kevmoo-old
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/mdv: remove reference to pkg/serialization IdentityMap is no longer used R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=27306

Patch Set 1 #

Patch Set 2 : removed old homepage while we're at it #

Total comments: 7

Patch Set 3 : added back homepage - with right url #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M pkg/mdv/lib/mdv.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/mdv/pubspec.yaml View 1 2 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kevmoo-old
Follow-up from r27284 https://codereview.chromium.org/23872008
7 years, 3 months ago (2013-09-09 18:59:15 UTC) #1
Jennifer Messerly
https://codereview.chromium.org/23724022/diff/4001/pkg/mdv/pubspec.yaml File pkg/mdv/pubspec.yaml (left): https://codereview.chromium.org/23724022/diff/4001/pkg/mdv/pubspec.yaml#oldcode2 pkg/mdv/pubspec.yaml:2: author: "Web UI Team <web-ui-dev@dartlang.org>" are you sure this ...
7 years, 3 months ago (2013-09-09 19:13:08 UTC) #2
Jennifer Messerly
https://codereview.chromium.org/23724022/diff/4001/pkg/mdv/pubspec.yaml File pkg/mdv/pubspec.yaml (left): https://codereview.chromium.org/23724022/diff/4001/pkg/mdv/pubspec.yaml#oldcode2 pkg/mdv/pubspec.yaml:2: author: "Web UI Team <web-ui-dev@dartlang.org>" On 2013/09/09 19:13:08, John ...
7 years, 3 months ago (2013-09-09 19:13:53 UTC) #3
kevmoo-old
https://codereview.chromium.org/23724022/diff/4001/pkg/mdv/pubspec.yaml File pkg/mdv/pubspec.yaml (left): https://codereview.chromium.org/23724022/diff/4001/pkg/mdv/pubspec.yaml#oldcode2 pkg/mdv/pubspec.yaml:2: author: "Web UI Team <web-ui-dev@dartlang.org>" On 2013/09/09 19:13:08, John ...
7 years, 3 months ago (2013-09-09 19:22:27 UTC) #4
Jennifer Messerly
lgtm https://codereview.chromium.org/23724022/diff/4001/pkg/mdv/pubspec.yaml File pkg/mdv/pubspec.yaml (left): https://codereview.chromium.org/23724022/diff/4001/pkg/mdv/pubspec.yaml#oldcode2 pkg/mdv/pubspec.yaml:2: author: "Web UI Team <web-ui-dev@dartlang.org>" On 2013/09/09 19:22:27, ...
7 years, 3 months ago (2013-09-09 19:25:33 UTC) #5
kevmoo-old
7 years, 3 months ago (2013-09-09 19:29:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r27306 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698