Eliminating some dart2js warnings from polymer_expressions

Wanted to get these out of the way because I was working on some other analyzer bugs.

Still a number of warnings in visitor.dart, opened https://code.google.com/p/dart/issues/detail?id=12912 for those.

BUG=
R=justinfagnani@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26889

[justinfagnani, 2013-08-29 18:31:48]

Thanks Pete

https://codereview.chromium.org/23724005/diff/7001/pkg/polymer_expressions/li...
File pkg/polymer_expressions/lib/eval.dart (right):

https://codereview.chromium.org/23724005/diff/7001/pkg/polymer_expressions/li...
pkg/polymer_expressions/lib/eval.dart:78: filters.add((expr as
BinaryOperator).right);
I'd prefer not use casts when they can be avoided. How about:

while (expr is BinaryOperator) {
  BinaryOperator op = expr;
  if (op.operator == '|') continue;
  filters.add(op.right);
  expr = op.left;
}

https://codereview.chromium.org/23724005/diff/7001/pkg/polymer_expressions/li...
pkg/polymer_expressions/lib/eval.dart:84: property = (expr as Identifier).value;
Identifier ident = expr;
property = ident.value;

https://codereview.chromium.org/23724005/diff/7001/pkg/polymer_expressions/li...
File pkg/polymer_expressions/lib/expression.dart (right):

https://codereview.chromium.org/23724005/diff/7001/pkg/polymer_expressions/li...
pkg/polymer_expressions/lib/expression.dart:231: // TODO: Bug 11617- This class
should be optimized and standardized elsewhere.
I was going to add a has function to quiver this week. I can use this till it's
in a more official place.

[blois, 2013-08-29 19:43:22]

https://codereview.chromium.org/23724005/diff/7001/pkg/polymer_expressions/li...
File pkg/polymer_expressions/lib/eval.dart (right):

https://codereview.chromium.org/23724005/diff/7001/pkg/polymer_expressions/li...
pkg/polymer_expressions/lib/eval.dart:78: filters.add((expr as
BinaryOperator).right);
On 2013/08/29 18:31:49, justinfagnani wrote:
> I'd prefer not use casts when they can be avoided. How about:
> 
> while (expr is BinaryOperator) {
>   BinaryOperator op = expr;
>   if (op.operator == '|') continue;
>   filters.add(op.right);
>   expr = op.left;
> }

Done.

https://codereview.chromium.org/23724005/diff/7001/pkg/polymer_expressions/li...
pkg/polymer_expressions/lib/eval.dart:84: property = (expr as Identifier).value;
On 2013/08/29 18:31:49, justinfagnani wrote:
> Identifier ident = expr;
> property = ident.value;

Done.

https://codereview.chromium.org/23724005/diff/7001/pkg/polymer_expressions/li...
File pkg/polymer_expressions/lib/expression.dart (right):

https://codereview.chromium.org/23724005/diff/7001/pkg/polymer_expressions/li...
pkg/polymer_expressions/lib/expression.dart:231: // TODO: Bug 11617- This class
should be optimized and standardized elsewhere.
On 2013/08/29 18:31:49, justinfagnani wrote:
> I was going to add a has function to quiver this week. I can use this till
it's
> in a more official place.

Yeah, I did a version of it in dart:html but have it private. Would be great to
have in core, without it I think most hashes will be wrong.

[justinfagnani, 2013-08-29 19:43:53]

lgtm

[blois, 2013-08-29 19:46:43]

Committed patchset #2 manually as r26889 (presubmit successful).