Issue 23721012: Generate out.precompiled.js, not precompiled.js.

Issue 23721012: Generate out.precompiled.js, not precompiled.js. (Closed)

Created:
7 years, 3 months ago by ahe

Modified:
7 years, 3 months ago

Reviewers:
kasperl, kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Generate out.precompiled.js, not precompiled.js. BUG=http://dartbug.com/6880 R=kasperl@google.com, kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=27813

Patch Set 1 : #

Total comments: 4

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -46 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/dart2js.dart	View	2 chunks	+12 lines, -1 line	1 comment	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js/memory_compiler.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js/missing_file_test.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js/package_root_test.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js/unneeded_part_js_test.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	dart/tests/isolate/isolate.status	View	4 chunks	+2 lines, -4 lines	0 comments	Download
A +	dart/tests/isolate/spawn_uri_multi_test.dart	View	1 chunk	+9 lines, -2 lines	0 comments	Download
D	dart/tests/isolate/spawn_uri_negative_test.dart	View	1 chunk	+0 lines, -25 lines	0 comments	Download
M	dart/tools/testing/dart/test_suite.dart	View	1 chunk	+2 lines, -1 line	3 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

https://codereview.chromium.org/23721012/diff/3001/dart/sdk/lib/_internal/compiler/implementation/dart2js.dart File dart/sdk/lib/_internal/compiler/implementation/dart2js.dart (right): https://codereview.chromium.org/23721012/diff/3001/dart/sdk/lib/_internal/compiler/implementation/dart2js.dart#newcode316 dart/sdk/lib/_internal/compiler/implementation/dart2js.dart:316: print('Dart file ($input) compiled to $outputLanguage: $output'); Since I'm ...

7 years, 3 months ago (2013-09-23 17:13:42 UTC) #1

kustermann

LGTM with comment https://codereview.chromium.org/23721012/diff/3001/dart/tools/testing/dart/test_suite.dart File dart/tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/23721012/diff/3001/dart/tools/testing/dart/test_suite.dart#newcode971 dart/tools/testing/dart/test_suite.dart:971: You could add a String precompiledDartWrapperFilename ...

7 years, 3 months ago (2013-09-24 07:00:52 UTC) #3

ahe

Committed patchset #1 manually as r27813 (presubmit successful).

7 years, 3 months ago (2013-09-24 12:05:08 UTC) #4

ahe

7 years, 3 months ago (2013-09-24 12:13:34 UTC) #5

Message was sent while issue was closed.

Followed up in https://codereview.chromium.org/23726054/

https://codereview.chromium.org/23721012/diff/3001/dart/tools/testing/dart/te...
File dart/tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/23721012/diff/3001/dart/tools/testing/dart/te...
dart/tools/testing/dart/test_suite.dart:971: 
On 2013/09/24 07:00:52, kustermann wrote:
> You could add a
>   String precompiledDartWrapperFilename = '$tempDir/test.precompiled.js';
> instead of doing the hackisch "scriptPath.replaceFirst()".

Good idea. I'll follow-up with a CL.

Expand Messages | Collapse Messages