Avoid recursion in some of our SSA optimizations, and cache computed block.dominates(other) operati…

Avoid recursion in some of our SSA optimizations, and cache computed block.dominates(other) operations.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27471

[kasperl, 2013-09-13 08:01:27]

LGTM.

https://codereview.chromium.org/23721009/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (right):

https://codereview.chromium.org/23721009/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/nodes.dart:740: Map<HBasicBlock,
bool> cacheDominates;
I'd prefer dominatesCache. Do you feel like the lazy initialization of it is
important? Do we have many blocks that are never asked if they dominate
something?

https://codereview.chromium.org/23721009/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/23721009/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:1156: class
GVNWorkItem {
GvnWorkItem is easier to read.

[ngeoffray, 2013-09-13 10:11:24]

Thanks Kasper.

https://codereview.chromium.org/23721009/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (right):

https://codereview.chromium.org/23721009/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/nodes.dart:740: Map<HBasicBlock,
bool> cacheDominates;
On 2013/09/13 08:01:27, kasperl wrote:
> I'd prefer dominatesCache. Do you feel like the lazy initialization of it is
> important? Do we have many blocks that are never asked if they dominate
> something?

Yeah, we only ask it for a certain number of instructions in our optimizations
that some blocks never see.

https://codereview.chromium.org/23721009/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/23721009/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:1156: class
GVNWorkItem {
On 2013/09/13 08:01:27, kasperl wrote:
> GvnWorkItem is easier to read.

Done.

[ngeoffray, 2013-09-13 10:12:27]

Committed patchset #3 manually as r27471 (presubmit successful).