Issue 23721006: test.py: Fixed incorrect handling of multitest in status files, status file cleanups.

Issue 23721006: test.py: Fixed incorrect handling of multitest in status files, status file cleanups. (Closed)

Created:
7 years, 3 months ago by kustermann

Modified:
7 years, 3 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

test.py: Fixed incorrect handling of multitest in status files, status file cleanups. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=27013

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -121 lines)			Patch
M	dart/tests/corelib/corelib.status	View		3 chunks	+1 line, -16 lines	0 comments	Download
M	dart/tests/language/language_dart2js.status	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	dart/tests/lib/analyzer/analyze_tests.status	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	dart/tests/lib/lib.status	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	dart/tools/testing/dart/multitest.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	dart/tools/testing/dart/test_options.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	dart/tools/testing/dart/test_suite.dart	View	1	14 chunks	+110 lines, -91 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://codereview.chromium.org/23721006/diff/1/dart/tools/testing/dart/test_suite.dart File dart/tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/23721006/diff/1/dart/tools/testing/dart/test_suite.dart#newcode259 dart/tools/testing/dart/test_suite.dart:259: Function doTest; this is an abstract class, can't ...

7 years, 3 months ago (2013-09-02 09:04:20 UTC) #2

kustermann

https://codereview.chromium.org/23721006/diff/1/dart/tools/testing/dart/test_suite.dart File dart/tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/23721006/diff/1/dart/tools/testing/dart/test_suite.dart#newcode259 dart/tools/testing/dart/test_suite.dart:259: Function doTest; On 2013/09/02 09:04:20, ricow1 wrote: > this ...

7 years, 3 months ago (2013-09-02 10:47:34 UTC) #3

kustermann

Committed patchset #2 manually as r27013 (presubmit successful).

7 years, 3 months ago (2013-09-02 14:05:19 UTC) #4

ricow1

7 years, 3 months ago (2013-09-02 14:08:42 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/23721006/diff/1/dart/tools/testing/dart/test_...
File dart/tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/23721006/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_suite.dart:259: Function doTest;
On 2013/09/02 10:47:34, kustermann wrote:
> On 2013/09/02 09:04:20, ricow1 wrote:
> > this is an abstract class, can't we just have an abstract method?
> 
> Just because it's an abstract class doesn't mean that all methods/fields must
be
> abstract.
> 
> This 'Function doTest' was common in all subclasses so I've just moved it up
> here.
Of course it does not - but _why_ not make this an abstract method instead?

Expand Messages | Collapse Messages