Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 23717003: Reorganize tests for samples so the test is discoverable from the sample (Closed)

Created:
7 years, 3 months ago by Jennifer Messerly
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reorganize tests for samples so the test is discoverable from the sample This change gets rid of the legacy "samples/test/samples/samples.status" folder structure. Instead it moves to "samples/samples.status", and each sample's test moves into its "test" folder. The benefit is less "..", easier to find the test for the sample, matching the structure of "pkg" and reducing levels of nesting. My other motivation is to help fix https://code.google.com/p/dart/issues/detail?id=12865, and generally make it easier to write tests for the web samples. R=devoncarew@google.com, sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=26831

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -2721 lines) Patch
A + samples/build_dart/test/build_dart_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + samples/build_dart_simple/test/build_dart_simple_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + samples/chat/test/chat_server_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + samples/clock/test/clock_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
A + samples/dartcombat/test/dartcombat_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + samples/hi/test/hi_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
A + samples/sample_extension/test/sample_extension_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
A samples/samples.status View 1 chunk +82 lines, -0 lines 1 comment Download
A + samples/solar/test/solar_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
A + samples/spirodraw/test/spirodraw_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
A + samples/sunflower/test/sunflower_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
A + samples/swarm/test/swarm_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download
A + samples/swarm/test/swarm_ui_lib/layout/css.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/swarm/test/swarm_ui_lib/layout/grid_examples.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/swarm/test/swarm_ui_lib/layout/grid_layout_demo.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/swarm/test/swarm_ui_lib/layout/grid_layout_demo.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/swarm/test/swarm_ui_lib/layout/layout.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/swarm/test/swarm_ui_lib/layout/layout.scss View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/swarm/test/swarm_ui_lib/layout/layout_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
A + samples/swarm/test/swarm_ui_lib/observable/abstract_observable_tests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/swarm/test/swarm_ui_lib/observable/change_event_tests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/swarm/test/swarm_ui_lib/observable/event_batch_tests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/swarm/test/swarm_ui_lib/observable/observable_list_tests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/swarm/test/swarm_ui_lib/observable/observable_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + samples/swarm/test/swarm_ui_lib/observable/observable_value_tests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + samples/swarm/test/swarm_ui_lib/touch/touch_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + samples/swarm/test/swarm_ui_lib/util/util_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + samples/swarm/test/swarm_ui_lib/view/view_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + samples/swipe/test/swipe_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
D samples/tests/samples/browser/clock_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D samples/tests/samples/browser/hi_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D samples/tests/samples/browser/solar_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D samples/tests/samples/browser/spirodraw_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D samples/tests/samples/browser/sunflower_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D samples/tests/samples/browser/swipe_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D samples/tests/samples/chat/chat_server_test.dart View 1 chunk +0 lines, -320 lines 0 comments Download
D samples/tests/samples/dartcombat/dartcombat_test.dart View 1 chunk +0 lines, -179 lines 0 comments Download
D samples/tests/samples/lib/layout/css.dart View 1 chunk +0 lines, -350 lines 0 comments Download
D samples/tests/samples/lib/layout/grid_examples.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D samples/tests/samples/lib/layout/grid_layout_demo.dart View 1 chunk +0 lines, -128 lines 0 comments Download
D samples/tests/samples/lib/layout/grid_layout_demo.html View 1 chunk +0 lines, -12 lines 0 comments Download
D samples/tests/samples/lib/layout/layout.css View 1 chunk +0 lines, -18 lines 0 comments Download
D samples/tests/samples/lib/layout/layout.scss View 1 chunk +0 lines, -316 lines 0 comments Download
D samples/tests/samples/lib/layout/layout_test.dart View 1 chunk +0 lines, -193 lines 0 comments Download
D samples/tests/samples/lib/observable/abstract_observable_tests.dart View 1 chunk +0 lines, -75 lines 0 comments Download
D samples/tests/samples/lib/observable/change_event_tests.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D samples/tests/samples/lib/observable/event_batch_tests.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D samples/tests/samples/lib/observable/observable_list_tests.dart View 1 chunk +0 lines, -120 lines 0 comments Download
D samples/tests/samples/lib/observable/observable_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D samples/tests/samples/lib/observable/observable_value_tests.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D samples/tests/samples/lib/touch/touch_test.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D samples/tests/samples/lib/util/util_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D samples/tests/samples/lib/view/view_test.dart View 1 chunk +0 lines, -205 lines 0 comments Download
D samples/tests/samples/samples.status View 1 chunk +0 lines, -76 lines 0 comments Download
D samples/tests/samples/standalone/build_dart_simple_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D samples/tests/samples/standalone/build_dart_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D samples/tests/samples/standalone/sample_extension_test.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D samples/tests/samples/standalone/time_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D samples/tests/samples/swarm/swarm_test.dart View 1 chunk +0 lines, -159 lines 0 comments Download
A + samples/time/test/time_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Jennifer Messerly
Hi Devon & Siggi, I don't know that we have an owner for samples tests, ...
7 years, 3 months ago (2013-08-28 20:51:35 UTC) #1
Siggi Cherem (dart-lang)
I like it! LGTM
7 years, 3 months ago (2013-08-28 22:03:41 UTC) #2
devoncarew
lgtm
7 years, 3 months ago (2013-08-28 22:09:27 UTC) #3
Jennifer Messerly
Committed patchset #1 manually as r26831 (presubmit successful).
7 years, 3 months ago (2013-08-29 00:26:24 UTC) #4
ricow1
7 years, 3 months ago (2013-08-29 06:46:35 UTC) #5
Message was sent while issue was closed.
DBC: Awesome change :-)

Powered by Google App Engine
This is Rietveld 408576698