Issue 23716002: Update the tests testing the use of built in identifiers

Issue 23716002: Update the tests testing the use of built in identifiers (Closed)

Created:
7 years, 3 months ago by Søren Gjesse

Modified:
7 years, 3 months ago

Reviewers:
ahe, kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update the tests testing the use of built in identifiers Updated the actual list of built in identifiers as of the current spec (0.51). Changed the names of the tests from pseudo_kw_* to built_in_identifier_* Try to track the actual identifiers which are not working in dart2js. R=ahe@google.com, kustermann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27117

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -175 lines)			Patch
A +	tests/language/built_in_identifier_illegal_test.dart	View		2 chunks	+3 lines, -1 line	0 comments	Download
A +	tests/language/built_in_identifier_test.dart	View		6 chunks	+28 lines, -27 lines	1 comment	Download
M	tests/language/language_analyzer.status	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	4 chunks	+2 lines, -5 lines	0 comments	Download
D	tests/language/pseudo_kw_illegal_test.dart	View		1 chunk	+0 lines, -22 lines	0 comments	Download
D	tests/language/pseudo_kw_test.dart	View		1 chunk	+0 lines, -115 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/23716002/diff/5001/tests/language/built_in_identifier_test.dart File tests/language/built_in_identifier_test.dart (right): https://codereview.chromium.org/23716002/diff/5001/tests/language/built_in_identifier_test.dart#newcode41 tests/language/built_in_identifier_test.dart:41: return 0; /// 01: ok I suspect there ...

7 years, 3 months ago (2013-09-04 11:52:39 UTC) #4

Søren Gjesse

7 years, 3 months ago (2013-09-04 12:10:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r27117 (presubmit successful).

Expand Messages | Collapse Messages