Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 237123003: Support unmapped areas in source maps. (Closed)

Created:
6 years, 8 months ago by zarah
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support unmapped areas in source maps. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=35307

Patch Set 1 : #

Total comments: 16

Patch Set 2 : Adressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -18 lines) Patch
M pkg/source_maps/lib/builder.dart View 1 1 chunk +1 line, -6 lines 0 comments Download
M pkg/source_maps/lib/parser.dart View 1 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/source_maps/pubspec.yaml View 1 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/source_maps/test/parser_test.dart View 1 2 chunks +66 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
zarah
While working with validating the source maps generated by dart2js I encountered the problem of ...
6 years, 8 months ago (2014-04-14 16:45:24 UTC) #1
Johnni Winther
LGTM but wait for Siggi's approval. https://codereview.chromium.org/237123003/diff/20001/pkg/source_maps/test/parse_map_with_no_source_location_test.dart File pkg/source_maps/test/parse_map_with_no_source_location_test.dart (right): https://codereview.chromium.org/237123003/diff/20001/pkg/source_maps/test/parse_map_with_no_source_location_test.dart#newcode12 pkg/source_maps/test/parse_map_with_no_source_location_test.dart:12: const Map<String, dynamic>MAP_WITH_NO_SOURCE_LOCATION ...
6 years, 8 months ago (2014-04-15 06:50:19 UTC) #2
Siggi Cherem (dart-lang)
Hi Sarah, Thanks for sending this change! I had this in my backlog for a ...
6 years, 8 months ago (2014-04-18 02:00:31 UTC) #3
Siggi Cherem (dart-lang)
I looked more and can't find anything that will let me reproduce the original issue ...
6 years, 8 months ago (2014-04-22 18:12:44 UTC) #4
zarah
Thanks for the comments! https://codereview.chromium.org/237123003/diff/20001/pkg/source_maps/lib/builder.dart File pkg/source_maps/lib/builder.dart (right): https://codereview.chromium.org/237123003/diff/20001/pkg/source_maps/lib/builder.dart#newcode120 pkg/source_maps/lib/builder.dart:120: if (oldValue == null) { ...
6 years, 8 months ago (2014-04-23 07:52:12 UTC) #5
zarah
6 years, 8 months ago (2014-04-23 07:57:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r35307 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698