Issue 23711004: Fix number scanning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23711004: Fix number scanning (Closed)

Created:
7 years, 3 months ago by hausner

Modified:
7 years, 3 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix number scanning Removing an old, Dash-era hack that makes 2is a faulty number literal rather than the number 2 followed by the identifier or keyword "is". Also fix number_identifier_test.dart which contains an access to a non-existent getter "memberName" of class NoSuchMethodError. Committed: https://code.google.com/p/dart/source/detail?r=27216

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -11 lines)			Patch
M	runtime/vm/scanner.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/number_identifier_test.dart	View		2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hausner

Committed patchset #2 manually as r27216 (presubmit successful).

7 years, 3 months ago (2013-09-05 22:11:54 UTC) #3

Message was sent while issue was closed.

LGTM -ip

Expand Messages | Collapse Messages