Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issue 23710088: Status file update after adding new vm-linux-release-optcounter-threshold builder (Closed)

Created:
7 years, 3 months ago by kustermann
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Status file update after adding new vm-linux-release-optcounter-threshold builder TBR=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=27815

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M pkg/pkg.status View 1 chunk +10 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +6 lines, -0 lines 2 comments Download
M tests/lib/lib.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kustermann
7 years, 3 months ago (2013-09-24 12:17:30 UTC) #1
kustermann
Committed patchset #1 manually as r27815 (presubmit successful).
7 years, 3 months ago (2013-09-24 12:19:19 UTC) #2
ricow1
LGTM https://codereview.chromium.org/23710088/diff/1/tests/co19/co19-runtime.status File tests/co19/co19-runtime.status (right): https://codereview.chromium.org/23710088/diff/1/tests/co19/co19-runtime.status#newcode153 tests/co19/co19-runtime.status:153: LibTest/typed_data/Float32x4/clamp_A01_t01: Pass, Fail # Issue 13543 are they ...
7 years, 3 months ago (2013-09-24 12:20:21 UTC) #3
Florian Schneider
On 2013/09/24 12:19:19, kustermann wrote: > Committed patchset #1 manually as r27815 (presubmit successful). LGTM. ...
7 years, 3 months ago (2013-09-24 12:25:58 UTC) #4
kustermann
7 years, 3 months ago (2013-09-24 12:36:27 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/23710088/diff/1/tests/co19/co19-runtime.status
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/23710088/diff/1/tests/co19/co19-runtime.statu...
tests/co19/co19-runtime.status:153: LibTest/typed_data/Float32x4/clamp_A01_t01:
Pass, Fail # Issue 13543
On 2013/09/24 12:20:22, ricow1 wrote:
> are they really flaky, I saw those consistently fail on my machine a few days
> back

They started to fail on my machine after enabling the optimization threshold.
=> We can't determine in a status file if we've set the low optimization counter
threshold or not, so we *need* to mark them as flaky.

Powered by Google App Engine
This is Rietveld 408576698