Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 23703004: Fix error message for NoSuchMethodError to not contain "Symbol". (Closed)

Created:
7 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix error message for NoSuchMethodError to not contain "Symbol". R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=27004

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/lib/errors_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
7 years, 3 months ago (2013-09-02 09:32:13 UTC) #1
Florian Schneider
LGTM.
7 years, 3 months ago (2013-09-02 09:33:26 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 manually as r27004 (presubmit successful).
7 years, 3 months ago (2013-09-02 09:33:59 UTC) #3
ricow1
7 years, 3 months ago (2013-09-02 10:50:37 UTC) #4
Message was sent while issue was closed.
How about a test for this so that we don't need to rely on dartium builders to
catch this?

Powered by Google App Engine
This is Rietveld 408576698