Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 23702037: Fix error handling when current working directory is deleted. (Closed)

Created:
7 years, 3 months ago by Bill Hesse
Modified:
7 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix error handling when current working directory is deleted. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27433

Patch Set 1 #

Patch Set 2 : Add Windows error handling. #

Patch Set 3 : Add Windows support #

Patch Set 4 : Fix type of _Directory._current #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M runtime/bin/directory.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/directory_patch.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/directory_win.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/lib/io_patch.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/directory_impl.dart View 1 2 3 2 chunks +9 lines, -2 lines 0 comments Download
M tests/standalone/io/directory_chdir_test.dart View 1 2 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
7 years, 3 months ago (2013-09-12 09:53:55 UTC) #1
Søren Gjesse
lgtm
7 years, 3 months ago (2013-09-12 10:41:37 UTC) #2
Bill Hesse
Changed directory_chdir_test.dart, and directory_win.cc, PTAL.
7 years, 3 months ago (2013-09-12 12:21:04 UTC) #3
Søren Gjesse
lgtm
7 years, 3 months ago (2013-09-12 12:29:54 UTC) #4
Bill Hesse
7 years, 3 months ago (2013-09-12 14:30:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r27433 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698