Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2369953004: Don't expect a `null` return from subscription.cancel. (Closed)

Created:
4 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 2 months ago
Reviewers:
nweiz, floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/stream_group_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
4 years, 2 months ago (2016-09-27 09:43:31 UTC) #2
floitsch
LGTM.
4 years, 2 months ago (2016-09-27 09:47:32 UTC) #3
Lasse Reichstein Nielsen
4 years, 2 months ago (2016-09-27 10:19:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1579e908f2e78b59a8c2732d88c6fea82689933c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698