Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 23694002: Fix run_zoned6|9_test. (Closed)

Created:
7 years, 3 months ago by floitsch
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix test. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M tests/lib/async/run_zoned6_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M tests/lib/async/run_zoned9_test.dart View 1 2 chunks +3 lines, -5 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -1 line 2 comments Download

Messages

Total messages: 6 (0 generated)
floitsch
I haven't tested on IE9 yet, but you said that this was the reason for ...
7 years, 3 months ago (2013-08-28 09:30:43 UTC) #1
kustermann
LGTM with comments. Yes we saw this mostly on IE (that's really timing dependendt). https://codereview.chromium.org/23694002/diff/1/tests/lib/async/run_zoned9_test.dart ...
7 years, 3 months ago (2013-08-28 10:34:01 UTC) #2
floitsch
7 years, 3 months ago (2013-08-28 12:20:23 UTC) #3
floitsch
Committed patchset #2 manually as r26784 (presubmit successful).
7 years, 3 months ago (2013-08-28 12:20:43 UTC) #4
Lasse Reichstein Nielsen
https://codereview.chromium.org/23694002/diff/6001/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/23694002/diff/6001/tests/lib/lib.status#newcode139 tests/lib/lib.status:139: run_zoned9_test/01: fail # Issue 12756. Consider changing "fail" to ...
7 years, 3 months ago (2013-08-28 12:28:21 UTC) #5
floitsch
7 years, 3 months ago (2013-08-28 12:30:48 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/23694002/diff/6001/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/23694002/diff/6001/tests/lib/lib.status#newco...
tests/lib/lib.status:139: run_zoned9_test/01: fail # Issue 12756.
On 2013/08/28 12:28:21, Lasse Reichstein Nielsen wrote:
> Consider changing "fail" to "Fail".

already committed.

Powered by Google App Engine
This is Rietveld 408576698