Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 23691029: Update language.status and rewrite some tests (Closed)

Created:
7 years, 3 months ago by Søren Gjesse
Modified:
7 years, 3 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update language.status and rewrite some tests Changed a number of negative tests to multi-tests R=kustermann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27062

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review commetns #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -117 lines) Patch
M tests/language/constructor_return_test.dart View 1 1 chunk +17 lines, -0 lines 0 comments Download
D tests/language/constructor_return_with_arrow_negative_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/constructor_return_with_init_and_arrow_negative_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/language/constructor_return_with_init_negative_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/language/instantiate_type_variable_negative_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download
A + tests/language/instantiate_type_variable_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +1 line, -2 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +1 line, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 3 chunks +18 lines, -14 lines 0 comments Download
D tests/language/list_literal1_negative_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
A + tests/language/list_literal1_test.dart View 1 chunk +3 lines, -9 lines 0 comments Download
D tests/language/map_literal1_negative_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
A + tests/language/map_literal1_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
7 years, 3 months ago (2013-09-03 13:31:15 UTC) #1
kustermann
LGTM https://codereview.chromium.org/23691029/diff/1/tests/language/constructor_return_with_init_test.dart File tests/language/constructor_return_with_init_test.dart (right): https://codereview.chromium.org/23691029/diff/1/tests/language/constructor_return_with_init_test.dart#newcode1 tests/language/constructor_return_with_init_test.dart:1: // Copyright (c) 2011, the Dart project authors. ...
7 years, 3 months ago (2013-09-03 13:42:09 UTC) #2
Søren Gjesse
Merged all the constructor return tests into constructor_return_test.dart. https://codereview.chromium.org/23691029/diff/1/tests/language/constructor_return_with_init_test.dart File tests/language/constructor_return_with_init_test.dart (right): https://codereview.chromium.org/23691029/diff/1/tests/language/constructor_return_with_init_test.dart#newcode1 tests/language/constructor_return_with_init_test.dart:1: // ...
7 years, 3 months ago (2013-09-03 14:38:36 UTC) #3
kustermann
LGTM
7 years, 3 months ago (2013-09-03 14:50:22 UTC) #4
Søren Gjesse
7 years, 3 months ago (2013-09-03 14:54:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r27062 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698