Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Issue 23691013: Add checks catching potential integer overflows. (Closed)

Created:
7 years, 3 months ago by Michael Lippautz (Google)
Modified:
7 years, 3 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add checks catching potential integer overflows. BUG= R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M runtime/vm/object.cc View 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Lippautz (Google)
7 years, 3 months ago (2013-08-29 21:16:57 UTC) #1
siva
lgtm
7 years, 3 months ago (2013-08-30 00:00:34 UTC) #2
Michael Lippautz (Google)
7 years, 3 months ago (2013-08-30 16:10:22 UTC) #3
Message was sent while issue was closed.
FYI: this is commited as r26924. codereview didn't feel like updating the
issue...

Powered by Google App Engine
This is Rietveld 408576698