Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 23691008: Compress memory usage. Imprive speed of finding exception handlers: if a code does not have any han… (Closed)

Created:
7 years, 3 months ago by srdjan
Modified:
7 years, 3 months ago
Reviewers:
hausner, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Compress memory usage. Imprive speed of finding exception handlers: if a code does not have any handlers, do not reaverse the PC descriptors. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26880

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -17 lines) Patch
M runtime/vm/exceptions.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/object.h View 1 2 2 chunks +16 lines, -8 lines 0 comments Download
M runtime/vm/object.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M runtime/vm/raw_object.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stack_frame.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
srdjan
7 years, 3 months ago (2013-08-29 15:56:52 UTC) #1
siva
lgtm https://codereview.chromium.org/23691008/diff/8001/runtime/vm/exceptions.cc File runtime/vm/exceptions.cc (right): https://codereview.chromium.org/23691008/diff/8001/runtime/vm/exceptions.cc#newcode369 runtime/vm/exceptions.cc:369: // 'error_class' is not a predefined class. // ...
7 years, 3 months ago (2013-08-29 16:29:20 UTC) #2
srdjan
https://codereview.chromium.org/23691008/diff/8001/runtime/vm/exceptions.cc File runtime/vm/exceptions.cc (right): https://codereview.chromium.org/23691008/diff/8001/runtime/vm/exceptions.cc#newcode369 runtime/vm/exceptions.cc:369: // 'error_class' is not a predefined class. On 2013/08/29 ...
7 years, 3 months ago (2013-08-29 16:38:12 UTC) #3
srdjan
7 years, 3 months ago (2013-08-29 16:47:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r26880 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698