Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 23688003: Make the result of JSON.decode be marked by "null" in the reviver. (Closed)

Created:
7 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 3 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make the result of JSON.decode be marked by "null" in the reviver. They are currently marked by "", which can match a property as well. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=26768

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M runtime/lib/convert_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/lib/convert_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/json/json.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/lib/convert/codec2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 3 months ago (2013-08-28 08:16:17 UTC) #1
floitsch
LGTM.
7 years, 3 months ago (2013-08-28 08:24:12 UTC) #2
Lasse Reichstein Nielsen
7 years, 3 months ago (2013-08-28 08:25:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26768 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698