Polymorphic inlining of [] operations.

Polymorphic inlining of [] operations.

This CL adds the necessary parts to enable polymorphic
inlining of recognized methods. For now it handles only
[]-calls. This helps code that deals with e.g. growable
and fixed-length lists.

The basic idea is to adapt the code in the flow graph
optimizer so that it can be used from the generic inliner.
Currently this adds a bit of boilerplate code which I intend
to reduce when adding more recognized methods to be handled.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27627

[Florian Schneider, 2013-09-13 13:27:46]

Redirecting to Kevin.

[Florian Schneider, 2013-09-17 08:58:51]

@John: Would you mind taking a look? Kevin and Srdjan are not available at the
moment.

[Cutch, 2013-09-17 16:08:47]

https://codereview.chromium.org/23684059/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/23684059/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:1069: // TODO(fschneider): Extend to other
recognized methods.
The below code is specific to preparing an indexed operation, can it be factored
out now in anticipation of supporting other recognized methods inside
::TryInlineRecognizedMethod?

https://codereview.chromium.org/23684059/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:1142: // Assume mixed Mint/Smi if this
instruction caused deoptimization once.
Shouldn't this include kTypedDataInt64ArrayCid and kTypedDataUint64ArrayCid?
They can be outside of the Smi range.

https://codereview.chromium.org/23684059/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:1184: case kTypedDataUint32ArrayCid:
Ahh, I see we never supported unboxed loads from 64-bit integer lists.

[Florian Schneider, 2013-09-18 14:00:36]

Refactored TryInlineRecognizedMethod and got rid of the template parameter.

https://codereview.chromium.org/23684059/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/23684059/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:1069: // TODO(fschneider): Extend to other
recognized methods.
On 2013/09/17 16:08:47, Cutch wrote:
> The below code is specific to preparing an indexed operation, can it be
factored
> out now in anticipation of supporting other recognized methods inside
> ::TryInlineRecognizedMethod?

Yes, I'd have to do that for the next CL anyway.

[Cutch, 2013-09-18 14:04:24]

lgtm

[Florian Schneider, 2013-09-18 15:42:00]

Committed patchset #5 manually as r27627 (presubmit successful).