Issue 23684057: Support new import rules.

Issue 23684057: Support new import rules. (Closed)

Created:
7 years, 3 months ago by Johnni Winther

Modified:
7 years, 3 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support new import rules. BUG=http://dartbug.com/12723 R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=27560

Patch Set 3 : Updated cf. comments. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -48 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart2js.dart	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	1 2	1 chunk	+25 lines, -9 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/library_loader.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View	1 2	2 chunks	+62 lines, -3 lines	0 comments	Download
M	tests/co19/co19-co19.status	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	tests/compiler/dart2js/diagnose_ambiguous_test.dart	View	1 2	2 chunks	+0 lines, -12 lines	0 comments	Download
M	tests/compiler/dart2js/message_kind_helper.dart	View		3 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

https://codereview.chromium.org/23684057/diff/1/sdk/lib/_internal/compiler/implementation/library_loader.dart File sdk/lib/_internal/compiler/implementation/library_loader.dart (right): https://codereview.chromium.org/23684057/diff/1/sdk/lib/_internal/compiler/implementation/library_loader.dart#newcode568 sdk/lib/_internal/compiler/implementation/library_loader.dart:568: compiler.withCurrentElement(importingLibrary, () { Errors reported on [import] pointed to ...

7 years, 3 months ago (2013-09-12 10:49:16 UTC) #1

ahe

LGTM! https://codereview.chromium.org/23684057/diff/1/sdk/lib/_internal/compiler/implementation/elements/modelx.dart File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right): https://codereview.chromium.org/23684057/diff/1/sdk/lib/_internal/compiler/implementation/elements/modelx.dart#newcode684 sdk/lib/_internal/compiler/implementation/elements/modelx.dart:684: listener.reportMessage( reportWarning. https://codereview.chromium.org/23684057/diff/1/sdk/lib/_internal/compiler/implementation/elements/modelx.dart#newcode694 sdk/lib/_internal/compiler/implementation/elements/modelx.dart:694: listener.reportMessage( reportWarning https://codereview.chromium.org/23684057/diff/1/sdk/lib/_internal/compiler/implementation/warnings.dart File ...

7 years, 3 months ago (2013-09-17 10:47:18 UTC) #3

Johnni Winther

Committed patchset #3 manually as r27560 (presubmit successful).

7 years, 3 months ago (2013-09-17 11:51:31 UTC) #4

Johnni Winther

7 years, 3 months ago (2013-09-18 06:14:11 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/23684057/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/23684057/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:684:
listener.reportMessage(
On 2013/09/17 10:47:18, ahe wrote:
> reportWarning.

Done.

https://codereview.chromium.org/23684057/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:694:
listener.reportMessage(
On 2013/09/17 10:47:18, ahe wrote:
> reportWarning

Done.

https://codereview.chromium.org/23684057/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/23684057/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/warnings.dart:202: const {'main.dart':
"""
On 2013/09/17 10:47:18, ahe wrote:
> I think these examples would be easier to read if they were formatted
> differently. In particular if the filename is always on a line by itself.

Done.

https://codereview.chromium.org/23684057/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/warnings.dart:206: void main() {}""",
'future.dart': """
On 2013/09/17 10:47:18, ahe wrote:
> This is somewhat hard to read. Also, please add a newline at the end of the
> example.

Done.

Expand Messages | Collapse Messages