- Modify toDart to first do a simple lookup in the appropriate table before going down the templati…

- Modify toDart to first do a simple lookup in the appropriate table before going down the templatized
  morass of switch statements
- Add a returnToDart function so that the WeakPersistent Handle returned from a lookup/create of the wrapper
  could be returned as is without the need to call Dart_handleFromWeakPersistentHandle
- Use Dart_SetDoubleReturnValue for doubles

some DromaeoDartium numbers before this change:

CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(div) runs-per-second 84240.6
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-traverse nextSibling runs-per-second 207.91683326669332
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(*) runs-per-second 69599.2

some DromaeoDartium numbers after this change:

CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(div) runs-per-second 104252.4
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-traverse nextSibling runs-per-second 366.8
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(*) runs-per-second 94922.6

R=rmacnak@google.com, vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27710

[vsm, 2013-09-19 21:05:57]

lgtm!

I know the code is inconsistent about it, but I think we should follow google
style (e.g., line len) for new code:

http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Line_length

https://chromiumcodereview.appspot.com/23681014/diff/7001/tools/dom/scripts/g...
File tools/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/23681014/diff/7001/tools/dom/scripts/g...
tools/dom/scripts/generator.py:712: def return_to_dart_conversion(self, value,
interface_name=None, attributes=None):
nit: line len

https://chromiumcodereview.appspot.com/23681014/diff/7001/tools/dom/scripts/g...
tools/dom/scripts/generator.py:839: return 'Dart_SetReturnValue(args, %s)' %
self.to_dart_conversion(value, interface_name, attributes)
line len

[rmacnak, 2013-09-19 23:14:32]

LGTM

[siva, 2013-09-19 23:50:34]

https://chromiumcodereview.appspot.com/23681014/diff/7001/tools/dom/scripts/g...
File tools/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/23681014/diff/7001/tools/dom/scripts/g...
tools/dom/scripts/generator.py:712: def return_to_dart_conversion(self, value,
interface_name=None, attributes=None):
On 2013/09/19 21:05:57, vsm wrote:
> nit: line len

Done.

https://chromiumcodereview.appspot.com/23681014/diff/7001/tools/dom/scripts/g...
tools/dom/scripts/generator.py:839: return 'Dart_SetReturnValue(args, %s)' %
self.to_dart_conversion(value, interface_name, attributes)
On 2013/09/19 21:05:57, vsm wrote:
> line len

Done.

[siva, 2013-09-20 16:25:17]

Committed patchset #4 manually as r27710 (presubmit successful).