Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 23681004: Add passing status for standalone/oom_error_stacktrace_test on dart2js with runtime=none. (Closed)

Created:
7 years, 3 months ago by Bill Hesse
Modified:
7 years, 3 months ago
Reviewers:
ahe, kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add passing status for standalone/oom_error_stacktrace_test on dart2js with runtime=none. BUG= R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=26842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tests/standalone/standalone.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
Why isn't this failing on buildbot?
7 years, 3 months ago (2013-08-28 14:50:21 UTC) #1
kustermann
LGTM The buildbots don't run "$compiler == dart2js && $runtime == none".
7 years, 3 months ago (2013-08-28 14:51:51 UTC) #2
Bill Hesse
7 years, 3 months ago (2013-08-29 08:37:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26842 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698