Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 23680015: Fix bug in inferrer: a super constructor call goes through the visitSuperSend in the resolved visit… (Closed)

Created:
7 years, 3 months ago by ngeoffray
Modified:
7 years, 3 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug in inferrer: a super constructor call goes through the visitSuperSend in the resolved visitor. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=27289

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/language/inference_super_constructor_call_test.dart View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 3 months ago (2013-09-09 12:19:43 UTC) #1
karlklose
LGTM.
7 years, 3 months ago (2013-09-09 12:24:57 UTC) #2
ngeoffray
7 years, 3 months ago (2013-09-09 13:27:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r27289 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698