Issue 23674003: Update a language test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23674003: Update a language test (Closed)

Created:
7 years, 3 months ago by Søren Gjesse

Modified:
7 years, 3 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update a language test Added expected static type warning for abstract method in concrete class R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26869

Patch Set 1 #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -6 lines)			Patch
M	tests/language/abstract_syntax_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/language/language_analyzer.status	View	1 chunk	+1 line, -1 line	2 comments	Download
M	tests/language/language_analyzer2.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/23674003/diff/1/tests/language/language_analyzer.status File tests/language/language_analyzer.status (right): https://codereview.chromium.org/23674003/diff/1/tests/language/language_analyzer.status#newcode83 tests/language/language_analyzer.status:83: #abstract_syntax_test/none: fail # Issue 11575 Remove the line?

7 years, 3 months ago (2013-08-29 12:58:05 UTC) #2

Søren Gjesse

https://codereview.chromium.org/23674003/diff/1/tests/language/language_analyzer.status File tests/language/language_analyzer.status (right): https://codereview.chromium.org/23674003/diff/1/tests/language/language_analyzer.status#newcode83 tests/language/language_analyzer.status:83: #abstract_syntax_test/none: fail # Issue 11575 On 2013/08/29 12:58:05, ngeoffray ...

7 years, 3 months ago (2013-08-29 14:17:36 UTC) #3

Søren Gjesse

7 years, 3 months ago (2013-08-29 14:17:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r26869 (presubmit successful).

Expand Messages | Collapse Messages