Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 23668006: Run file system operations in file_system_watcher_test after a runAsync delay. (Closed)

Created:
7 years, 3 months ago by Anders Johnsen
Modified:
7 years, 3 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Run file system operations in file_system_watcher_test after a runAsync delay. This fixes the flakyness seen on Windows. BUG= R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M tests/standalone/io/file_system_watcher_test.dart View 7 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 3 months ago (2013-09-03 16:05:37 UTC) #1
Bill Hesse
lgtm
7 years, 3 months ago (2013-09-03 16:06:31 UTC) #2
Anders Johnsen
7 years, 3 months ago (2013-09-03 16:07:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27065 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698