Issue 23660008: Fix a bug in the variable allocator: a pure instruction between an inlined if and its inlined expre…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23660008: Fix a bug in the variable allocator: a pure instruction between an inlined if and its inlined expre… (Closed)

Created:
7 years, 3 months ago by ngeoffray

Modified:
7 years, 3 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix a bug in the variable allocator: a pure instruction between an inlined if and its inlined expression made the live instructions die before that pure instruction. So the pure instruction could just re-use an already taken variable name. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=27514

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -3 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart	View	3 chunks	+16 lines, -1 line	0 comments	Download
A	tests/language/inlined_conditional_test.dart	View	1 chunk	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

7 years, 3 months ago (2013-09-16 09:19:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27514 (presubmit successful).

Expand Messages | Collapse Messages