Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 23658055: Reinstate type checks in Math.min and Math.max (Closed)

Created:
7 years, 3 months ago by sra1
Modified:
7 years, 2 months ago
Reviewers:
srdjan, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Reinstate type checks in Math.min and Math.max See Issue 11906 for discussion. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=27980

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -2 lines) Patch
M runtime/vm/intermediate_language.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/math/math.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M tests/lib/math/min_max_test.dart View 1 2 3 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sra1
Srdjan - is there anything else required for the VM?
7 years, 3 months ago (2013-09-14 00:47:09 UTC) #1
sra1
Ping
7 years, 3 months ago (2013-09-17 21:26:58 UTC) #2
sra1
Siva - Srdjan is out, can you review? Specifically, is changing the fingerprint all I ...
7 years, 3 months ago (2013-09-19 22:40:43 UTC) #3
siva
I somehow don't like these additional redundant type tests that will be flagged in checked ...
7 years, 3 months ago (2013-09-20 00:36:16 UTC) #4
sra1
On 2013/09/20 00:36:16, siva wrote: > I somehow don't like these additional redundant type tests ...
7 years, 3 months ago (2013-09-20 01:13:23 UTC) #5
srdjan
lgtm https://chromiumcodereview.appspot.com/23658055/diff/7001/sdk/lib/math/math.dart File sdk/lib/math/math.dart (right): https://chromiumcodereview.appspot.com/23658055/diff/7001/sdk/lib/math/math.dart#newcode68 sdk/lib/math/math.dart:68: if (b is! num) throw new ArgumentError(b); Please ...
7 years, 2 months ago (2013-09-26 22:09:50 UTC) #6
sra1
7 years, 2 months ago (2013-09-27 00:45:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r27980 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698