Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 23658024: Add more filters to gitignore. (Closed)

Created:
7 years, 3 months ago by floitsch
Modified:
7 years, 3 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : No need for dartE, darte, dartee. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M .gitignore View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
floitsch
7 years, 3 months ago (2013-09-05 11:31:37 UTC) #1
ricow1
https://codereview.chromium.org/23658024/diff/1/.gitignore File .gitignore (right): https://codereview.chromium.org/23658024/diff/1/.gitignore#newcode62 .gitignore:62: *.dartE where are these placed? https://codereview.chromium.org/23658024/diff/1/.gitignore#newcode67 .gitignore:67: *.orig why ...
7 years, 3 months ago (2013-09-05 12:13:52 UTC) #2
floitsch
https://codereview.chromium.org/23658024/diff/1/.gitignore File .gitignore (right): https://codereview.chromium.org/23658024/diff/1/.gitignore#newcode62 .gitignore:62: *.dartE On 2013/09/05 12:13:52, ricow1 wrote: > where are ...
7 years, 3 months ago (2013-09-05 14:21:48 UTC) #3
floitsch
ping.
7 years, 3 months ago (2013-09-11 13:50:37 UTC) #4
ricow1
lgtm
7 years, 3 months ago (2013-09-11 15:01:54 UTC) #5
ricow1
lgtm
7 years, 3 months ago (2013-09-11 15:03:36 UTC) #6
floitsch
7 years, 3 months ago (2013-09-11 16:50:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r27394 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698