Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 23656005: Fix the merge of locals handler logic. (Closed)

Created:
7 years, 3 months ago by ngeoffray
Modified:
7 years, 3 months ago
Reviewers:
karlklose, ahe, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix the merge of locals handler logic. This currently works because there is no inferrer that make use of the creation of phis. I'm working on an experimental one that found these problems. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=27104

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -66 lines) Patch
M sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart View 1 10 chunks +80 lines, -57 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 1 2 chunks +0 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ngeoffray
https://codereview.chromium.org/23656005/diff/3001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (left): https://codereview.chromium.org/23656005/diff/3001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart#oldcode2299 sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:2299: // iterable. This was actually too defensive. currentType will ...
7 years, 3 months ago (2013-08-29 10:54:59 UTC) #1
ngeoffray
Kasper, Peter and Karl being away, could you please take a look?
7 years, 3 months ago (2013-09-04 07:43:34 UTC) #2
kasperl
LGTM!
7 years, 3 months ago (2013-09-04 08:04:43 UTC) #3
ngeoffray
Committed patchset #2 manually as r27104 (presubmit successful).
7 years, 3 months ago (2013-09-04 09:25:39 UTC) #4
ahe
7 years, 3 months ago (2013-09-04 12:03:29 UTC) #5
Message was sent while issue was closed.
Sorry for not replying sooner. I think I mostly understand what you're doing, so
LGTM!

Powered by Google App Engine
This is Rietveld 408576698