Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1397)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23654055: Move dart:chrome to dart:_chrome. (Closed)

Created:
7 years, 3 months ago by dgrove
Modified:
7 years, 3 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, benwells1
Visibility:
Public.

Description

Move dart:chrome to dart:_chrome. Turn off doc generation for dart:_chrome. R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=27861

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2611 lines) Patch
M + sdk/lib/_chrome/dart2js/chrome_dart2js.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M + sdk/lib/_chrome/dartium/chrome_dartium.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/libraries.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
D sdk/lib/chrome/dart2js/chrome_dart2js.dart View 1 1 chunk +0 lines, -1252 lines 0 comments Download
D sdk/lib/chrome/dartium/chrome_dartium.dart View 1 1 chunk +0 lines, -16 lines 0 comments Download
A + tests/_chrome/_chrome.status View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/_chrome/chrome.status View 1 1 chunk +0 lines, -11 lines 0 comments Download
M + tests/_chrome/sample_test.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
D tests/chrome/chrome.status View 1 1 chunk +0 lines, -11 lines 0 comments Download
D tests/chrome/sample_test.dart View 1 1 chunk +0 lines, -23 lines 0 comments Download
M tools/create_sdk.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/chromegenerator.py View 1 4 chunks +7 lines, -7 lines 0 comments Download
D tools/dom/src/chrome/app_runtime.dart View 1 1 chunk +0 lines, -157 lines 0 comments Download
D tools/dom/src/chrome/app_window.dart View 1 1 chunk +0 lines, -516 lines 0 comments Download
D tools/dom/src/chrome/chrome.dart View 1 1 chunk +0 lines, -70 lines 0 comments Download
D tools/dom/src/chrome/custom_dart/app_window.AppWindow.contentWindow.dart View 1 1 chunk +0 lines, -8 lines 1 comment Download
D tools/dom/src/chrome/custom_dart/app_window.AppWindow.getBounds.dart View 1 1 chunk +0 lines, -8 lines 0 comments Download
D tools/dom/src/chrome/custom_dart/app_window.create.dart View 1 1 chunk +0 lines, -16 lines 0 comments Download
D tools/dom/src/chrome/custom_dart/app_window.current.dart View 1 1 chunk +0 lines, -9 lines 0 comments Download
D tools/dom/src/chrome/file_system.dart View 1 1 chunk +0 lines, -193 lines 0 comments Download
D tools/dom/src/chrome/utils.dart View 1 1 chunk +0 lines, -295 lines 0 comments Download
M tools/dom/templates/html/dart2js/chrome_dart2js.darttemplate View 1 1 chunk +5 lines, -5 lines 0 comments Download
M tools/dom/templates/html/dartium/chrome_dartium.darttemplate View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dgrove
In addition to moving the library, stop publishing docs on api.dartlang.org .
7 years, 3 months ago (2013-09-24 23:23:35 UTC) #1
Emily Fortuna
quick question/comment: https://codereview.chromium.org/23654055/diff/6001/tools/dom/src/chrome/custom_dart/app_window.AppWindow.contentWindow.dart File tools/dom/src/chrome/custom_dart/app_window.AppWindow.contentWindow.dart (left): https://codereview.chromium.org/23654055/diff/6001/tools/dom/src/chrome/custom_dart/app_window.AppWindow.contentWindow.dart#oldcode7 tools/dom/src/chrome/custom_dart/app_window.AppWindow.contentWindow.dart:7: WindowBase get contentWindow => did these files ...
7 years, 3 months ago (2013-09-24 23:29:17 UTC) #2
dgrove
On 2013/09/24 23:29:17, Emily Fortuna wrote: > quick question/comment: > > https://codereview.chromium.org/23654055/diff/6001/tools/dom/src/chrome/custom_dart/app_window.AppWindow.contentWindow.dart > File tools/dom/src/chrome/custom_dart/app_window.AppWindow.contentWindow.dart ...
7 years, 3 months ago (2013-09-24 23:50:08 UTC) #3
dgrove
7 years, 3 months ago (2013-09-24 23:50:15 UTC) #4
Emily Fortuna
lgtm
7 years, 3 months ago (2013-09-24 23:50:23 UTC) #5
dgrove
7 years, 3 months ago (2013-09-24 23:52:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 manually as r27861 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698