Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 23647014: Updating custom element test to only load polyfill when needed. (Closed)

Created:
7 years, 3 months ago by blois
Modified:
7 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Updating custom element test to only load polyfill when needed. Also switching to a script element with a src, which I've found improves debuggability with some browsers. BUG=13231 R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=27456

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M pkg/custom_element/test/custom_element_test.dart View 1 chunk +8 lines, -8 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
blois
7 years, 3 months ago (2013-09-12 20:18:27 UTC) #1
Jennifer Messerly
lgtm https://codereview.chromium.org/23647014/diff/1/pkg/custom_element/test/custom_element_test.dart File pkg/custom_element/test/custom_element_test.dart (right): https://codereview.chromium.org/23647014/diff/1/pkg/custom_element/test/custom_element_test.dart#newcode22 pkg/custom_element/test/custom_element_test.dart:22: return script.onLoad.first; Nice! This blocks the test until ...
7 years, 3 months ago (2013-09-12 20:43:48 UTC) #2
blois
https://codereview.chromium.org/23647014/diff/1/pkg/custom_element/test/custom_element_test.dart File pkg/custom_element/test/custom_element_test.dart (right): https://codereview.chromium.org/23647014/diff/1/pkg/custom_element/test/custom_element_test.dart#newcode22 pkg/custom_element/test/custom_element_test.dart:22: return script.onLoad.first; On 2013/09/12 20:43:48, John Messerly wrote: > ...
7 years, 3 months ago (2013-09-12 21:23:13 UTC) #3
blois
7 years, 3 months ago (2013-09-12 22:24:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r27456 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698