Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 23645020: Add a hidden option to customize "pub serve"'s hostname. (Closed)

Created:
7 years, 3 months ago by nweiz
Modified:
7 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a hidden option to customize "pub serve"'s hostname. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27860

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M sdk/lib/_internal/pub/lib/src/command/serve.dart View 3 chunks +11 lines, -2 lines 4 comments Download
M sdk/lib/_internal/pub/test/serve/utils.dart View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
7 years, 3 months ago (2013-09-24 21:02:39 UTC) #1
Bob Nystrom
LGTM! https://codereview.chromium.org/23645020/diff/1/sdk/lib/_internal/pub/lib/src/command/serve.dart File sdk/lib/_internal/pub/lib/src/command/serve.dart (right): https://codereview.chromium.org/23645020/diff/1/sdk/lib/_internal/pub/lib/src/command/serve.dart#newcode39 sdk/lib/_internal/pub/lib/src/command/serve.dart:39: // 127.0.0.1. Do we have an actual bug ...
7 years, 3 months ago (2013-09-24 22:42:19 UTC) #2
nweiz
https://codereview.chromium.org/23645020/diff/1/sdk/lib/_internal/pub/lib/src/command/serve.dart File sdk/lib/_internal/pub/lib/src/command/serve.dart (right): https://codereview.chromium.org/23645020/diff/1/sdk/lib/_internal/pub/lib/src/command/serve.dart#newcode39 sdk/lib/_internal/pub/lib/src/command/serve.dart:39: // 127.0.0.1. On 2013/09/24 22:42:19, Bob Nystrom wrote: > ...
7 years, 3 months ago (2013-09-24 22:54:36 UTC) #3
nweiz
7 years, 3 months ago (2013-09-24 23:17:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r27860 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698