Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 23645015: Add bsr to ia32 disassembler (Closed)

Created:
7 years, 3 months ago by sra1
Modified:
7 years, 3 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add bsr to ia32 disassembler bsr is generated for bitLength. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=27674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/vm/disassembler_ia32.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sra1
7 years, 3 months ago (2013-09-19 03:52:57 UTC) #1
sra1
Srdjan is out - can you review?
7 years, 3 months ago (2013-09-19 16:35:09 UTC) #2
siva
lgtm
7 years, 3 months ago (2013-09-19 18:13:26 UTC) #3
sra1
7 years, 3 months ago (2013-09-19 19:52:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r27674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698