Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 23640004: Require case expressions to be compile-time constants (Closed)

Created:
7 years, 3 months ago by hausner
Modified:
7 years, 3 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Require case expressions to be compile-time constants Remove legacy semantics in switch statement compilation. Still to be added: analysis that all case expressions are of the same type. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=26749

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M runtime/vm/parser.cc View 5 chunks +8 lines, -14 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/switch_int_double_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
TIA!
7 years, 3 months ago (2013-08-27 22:03:54 UTC) #1
regis
LGTM
7 years, 3 months ago (2013-08-27 22:43:27 UTC) #2
hausner
7 years, 3 months ago (2013-08-27 23:08:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26749 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698