Merge two static_final_field tests and rewrite a negative test to a multi-test

Merge two static_final_field tests and rewrite a negative test to a multi-test

Removed negative static_final_field_negative_test.dart and created a
multi-test in static_final_field2_test.dart.

Changed throw7_negative_test.dart into a multi-test throw7_test.dart

More Expect.equals cleanup in scope_variable_test.dart.

Add more issue numbers as well.

R=kustermann@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=27123

[kustermann, 2013-09-04 11:13:01]

LGTM with comments.

https://codereview.chromium.org/23638006/diff/1/tests/language/static_final_f...
File tests/language/static_final_field2_test.dart (right):

https://codereview.chromium.org/23638006/diff/1/tests/language/static_final_f...
tests/language/static_final_field2_test.dart:15: static const c;  /// 02:
continued
I think the c is not adding any benefit here, does it?

https://codereview.chromium.org/23638006/diff/1/tests/language/throw7_test.dart
File tests/language/throw7_test.dart (right):

https://codereview.chromium.org/23638006/diff/1/tests/language/throw7_test.da...
tests/language/throw7_test.dart:15: on Exception catch (exception) { i = 3; } 
/// 01: compile-time error
Does the analyzer give a warning here as well?

[Søren Gjesse, 2013-09-04 12:58:52]

https://codereview.chromium.org/23638006/diff/1/tests/language/static_final_f...
File tests/language/static_final_field2_test.dart (right):

https://codereview.chromium.org/23638006/diff/1/tests/language/static_final_f...
tests/language/static_final_field2_test.dart:15: static const c;  /// 02:
continued
On 2013/09/04 11:13:01, kustermann wrote:
> I think the c is not adding any benefit here, does it?

I don't think so. I just copied from the original test and kept the same
constructs.

https://codereview.chromium.org/23638006/diff/1/tests/language/throw7_test.dart
File tests/language/throw7_test.dart (right):

https://codereview.chromium.org/23638006/diff/1/tests/language/throw7_test.da...
tests/language/throw7_test.dart:15: on Exception catch (exception) { i = 3; } 
/// 01: compile-time error
On 2013/09/04 11:13:01, kustermann wrote:
> Does the analyzer give a warning here as well?

Currently it just accepts it, issue 12159.

[kustermann, 2013-09-04 13:03:06]

https://codereview.chromium.org/23638006/diff/1/tests/language/throw7_test.dart
File tests/language/throw7_test.dart (right):

https://codereview.chromium.org/23638006/diff/1/tests/language/throw7_test.da...
tests/language/throw7_test.dart:15: on Exception catch (exception) { i = 3; } 
/// 01: compile-time error
On 2013/09/04 12:58:52, Søren Gjesse wrote:
> On 2013/09/04 11:13:01, kustermann wrote:
> > Does the analyzer give a warning here as well?
> 
> Currently it just accepts it, issue 12159.

If this *should* result in a warning, you should change this line to
/// 01: compile-time error, static type warning
right?

[Søren Gjesse, 2013-09-04 13:26:44]

Committed patchset #1 manually as r27123 (presubmit successful).

[Søren Gjesse, 2013-09-04 13:45:09]

On 2013/09/04 13:03:06, kustermann wrote:
>
https://codereview.chromium.org/23638006/diff/1/tests/language/throw7_test.dart
> File tests/language/throw7_test.dart (right):
> 
>
https://codereview.chromium.org/23638006/diff/1/tests/language/throw7_test.da...
> tests/language/throw7_test.dart:15: on Exception catch (exception) { i = 3; } 
> /// 01: compile-time error
> On 2013/09/04 12:58:52, Søren Gjesse wrote:
> > On 2013/09/04 11:13:01, kustermann wrote:
> > > Does the analyzer give a warning here as well?
> > 
> > Currently it just accepts it, issue 12159.
> 
> If this *should* result in a warning, you should change this line to
> /// 01: compile-time error, static type warning
> right?

Actually I was not able to find any information on this in the spec
https://www.dartlang.org/docs/spec/latest/dart-language-specification.html#h.....
I will ask Gilad.