Issue 23638003: Improve performance of exception handling: quicker (and correcter) determination if the exception c…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23638003: Improve performance of exception handling: quicker (and correcter) determination if the exception c… (Closed)

Created:
7 years, 3 months ago by srdjan

Modified:
7 years, 3 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improve performance of exception handling: quicker (and correcter) determination if the exception class extends class Error. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26888

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -9 lines)			Patch
	M	runtime/vm/exceptions.cc	View	1	1 chunk	+12 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/23638003/diff/1/runtime/vm/exceptions.cc File runtime/vm/exceptions.cc (right): https://codereview.chromium.org/23638003/diff/1/runtime/vm/exceptions.cc#newcode382 runtime/vm/exceptions.cc:382: Class& test_class = Class::Handle(isolate, instance.clazz()); // Comments ...

7 years, 3 months ago (2013-08-29 19:35:19 UTC) #1

srdjan

https://codereview.chromium.org/23638003/diff/1/runtime/vm/exceptions.cc File runtime/vm/exceptions.cc (right): https://codereview.chromium.org/23638003/diff/1/runtime/vm/exceptions.cc#newcode382 runtime/vm/exceptions.cc:382: Class& test_class = Class::Handle(isolate, instance.clazz()); On 2013/08/29 19:35:19, Ivan ...

7 years, 3 months ago (2013-08-29 19:37:29 UTC) #2

srdjan

7 years, 3 months ago (2013-08-29 19:38:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r26888 (presubmit successful).

Expand Messages | Collapse Messages