Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 236363015: Support loading transformers exported by packages' libraries. (Closed)

Created:
6 years, 8 months ago by nweiz
Modified:
6 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support loading transformers exported by packages' libraries. R=rnystrom@google.com RELNOTE=Pub will now load transformers exported by a package's library. Committed: https://code.google.com/p/dart/source/detail?r=35100

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -29 lines) Patch
M sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart View 1 1 chunk +40 lines, -23 lines 0 comments Download
A + sdk/lib/_internal/pub/test/transformer/loads_a_transformer_defined_in_an_exported_library_test.dart View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
6 years, 8 months ago (2014-04-15 21:53:06 UTC) #1
Bob Nystrom
https://codereview.chromium.org/236363015/diff/1/sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart File sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart (right): https://codereview.chromium.org/236363015/diff/1/sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart#newcode46 sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart:46: for (var dependency in library.libraryDependencies) { Add a little ...
6 years, 8 months ago (2014-04-15 22:21:46 UTC) #2
Bob Nystrom
One nit then LGTM.
6 years, 8 months ago (2014-04-15 22:21:56 UTC) #3
nweiz
https://codereview.chromium.org/236363015/diff/1/sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart File sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart (right): https://codereview.chromium.org/236363015/diff/1/sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart#newcode46 sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart:46: for (var dependency in library.libraryDependencies) { On 2014/04/15 22:21:46, ...
6 years, 8 months ago (2014-04-15 23:57:51 UTC) #4
nweiz
6 years, 8 months ago (2014-04-15 23:58:13 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r35100 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698