Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 23635003: Fixing first-chance exception in TodoMVC (Closed)

Created:
7 years, 3 months ago by blois
Modified:
7 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing first-chance exception in TodoMVC The object coming in was null and the property was a Symbol, so it was getting a null error in the mirror.getField. BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=26808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M pkg/observe/lib/src/path_observer.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
This is the last change to get TodoMVC starting up clean with first-chance exceptions :)
7 years, 3 months ago (2013-08-28 00:06:02 UTC) #1
Jennifer Messerly
lgtm
7 years, 3 months ago (2013-08-28 02:21:11 UTC) #2
blois
7 years, 3 months ago (2013-08-28 18:10:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26808 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698