Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 23631002: Fixing datalistelement test on Safari. (Closed)

Created:
7 years, 3 months ago by blois
Modified:
7 years, 3 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing datalistelement test on Safari. It's not supported on Safari, but this test wasn't actually exercising it so no failures. BUG=12797 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=26748

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M tests/html/datalistelement_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/html/html.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
7 years, 3 months ago (2013-08-27 20:00:08 UTC) #1
Emily Fortuna
am I missing something? I don't see an "options" getter/field http://api.dartlang.org/docs/bleeding_edge/dart_html/Element.html
7 years, 3 months ago (2013-08-27 22:06:40 UTC) #2
Emily Fortuna
lgtm!
7 years, 3 months ago (2013-08-27 22:32:03 UTC) #3
blois
7 years, 3 months ago (2013-08-27 22:34:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r26748 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698