Issue 23625008: Add support for chrome on windows to the new browser controller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23625008: Add support for chrome on windows to the new browser controller (Closed)

Created:
7 years, 3 months ago by ricow1

Modified:
7 years, 3 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add support for chrome on windows to the new browser controller R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=27239

Patch Set 3 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -8 lines)			Patch
	M	tools/testing/dart/browser_controller.dart	View	1 2	3 chunks	+17 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

LGTM https://chromiumcodereview.appspot.com/23625008/diff/1/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://chromiumcodereview.appspot.com/23625008/diff/1/tools/testing/dart/browser_controller.dart#newcode330 tools/testing/dart/browser_controller.dart:330: if (Platform.isLinux) return 'google-chrome'; Please add the path ...

7 years, 3 months ago (2013-09-06 09:24:55 UTC) #2

ricow1

https://chromiumcodereview.appspot.com/23625008/diff/1/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://chromiumcodereview.appspot.com/23625008/diff/1/tools/testing/dart/browser_controller.dart#newcode330 tools/testing/dart/browser_controller.dart:330: if (Platform.isLinux) return 'google-chrome'; On 2013/09/06 09:24:55, kustermann wrote: ...

7 years, 3 months ago (2013-09-06 09:40:21 UTC) #3

ricow1

7 years, 3 months ago (2013-09-06 09:45:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r27239 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23625008: Add support for chrome on windows to the new browser controller (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages