Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 23621022: Update language.status (Closed)

Created:
7 years, 3 months ago by Søren Gjesse
Modified:
7 years, 3 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update language.status Add some more issue numbers. Rewrite some tests R=kustermann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27193

Patch Set 1 #

Total comments: 4

Patch Set 2 : Changed testing of string identity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -131 lines) Patch
M tests/language/constructor_initializer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/language_dart2js.status View 1 6 chunks +8 lines, -24 lines 0 comments Download
D tests/language/optimization_test.dart View 1 chunk +0 lines, -100 lines 0 comments Download
A + tests/language/vm/optimization_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
7 years, 3 months ago (2013-09-05 10:54:23 UTC) #1
kustermann
Everything looks good except "expect_test.dart" https://codereview.chromium.org/23621022/diff/1/tests/language/expect_test.dart File tests/language/expect_test.dart (right): https://codereview.chromium.org/23621022/diff/1/tests/language/expect_test.dart#newcode51 tests/language/expect_test.dart:51: Expect.identical(new C(), ab); I ...
7 years, 3 months ago (2013-09-05 11:09:51 UTC) #2
Søren Gjesse
https://codereview.chromium.org/23621022/diff/1/tests/language/expect_test.dart File tests/language/expect_test.dart (right): https://codereview.chromium.org/23621022/diff/1/tests/language/expect_test.dart#newcode51 tests/language/expect_test.dart:51: Expect.identical(new C(), ab); On 2013/09/05 11:09:51, kustermann wrote: > ...
7 years, 3 months ago (2013-09-05 12:23:37 UTC) #3
kustermann
LGTM
7 years, 3 months ago (2013-09-05 12:25:27 UTC) #4
Søren Gjesse
7 years, 3 months ago (2013-09-05 12:37:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r27193 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698