Issue 23621008: Move the assertion checking the number of arguments passed to a runtime entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23621008: Move the assertion checking the number of arguments passed to a runtime entry (Closed)

Created:
7 years, 3 months ago by regis

Modified:
7 years, 3 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Kevin Millikin (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Move the assertion checking the number of arguments passed to a runtime entry from the entry to the macro. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26829

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -65 lines)			Patch
M	runtime/vm/code_generator.cc	View	35 chunks	+0 lines, -63 lines	0 comments	Download
M	runtime/vm/compiler.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/runtime_entry.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/runtime_entry_test.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

regis

7 years, 3 months ago (2013-08-29 00:08:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r26829 (presubmit successful).